Skip to content

unfurl_links=False for avoiding preview in slack messages#2064

Merged
GuyEshdat merged 1 commit intomasterfrom
disable-slack-link-preview
Dec 1, 2025
Merged

unfurl_links=False for avoiding preview in slack messages#2064
GuyEshdat merged 1 commit intomasterfrom
disable-slack-link-preview

Conversation

@GuyEshdat
Copy link
Copy Markdown
Contributor

@GuyEshdat GuyEshdat commented Dec 1, 2025 •
edited
Loading

Before the change:
image

After the change:
image

null

Summary by CodeRabbit

  • Bug Fixes
    • Updated Slack message handling to prevent automatic link unfurling, ensuring links display as plain text rather than expanded previews in messages.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2025

👋 @GuyEshdat
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 1, 2025 •
edited
Loading

Walkthrough

A single parameter unfurl_links=False was added to the Slack chat_postMessage API call in the Slack messaging integration module, preventing links from being unfurled when messages are posted to Slack.

Changes

Cohort / File(s) Summary
Slack API parameter configuration
elementary/messages/messaging_integrations/slack_web.py		 Added unfurl_links=False parameter to chat_postMessage call to disable link unfurling in Slack messages

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file change affecting one API call parameter
  • No logic or error handling modifications
  • Straightforward configuration adjustment

Poem

🐰 Links stay bundled, no unfurling display,
Messages stay neat in their own tidy way,
A param so small, but it changes the sight,
Slack posts now cleaner—what a delight! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding unfurl_links=False parameter to Slack messages to prevent link previews.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch disable-slack-link-preview

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
elementary/messages/messaging_integrations/slack_web.py (1)

107-107: Parameter support confirmed. The unfurl_links=False parameter is fully supported in slack-sdk's chat_postMessage method and correctly prevents link previews in Slack messages.

Consider making this configurable via a constructor parameter if different behavior is needed in the future.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 68e48a0 and 95cb22d.

📒 Files selected for processing (1)
  • elementary/messages/messaging_integrations/slack_web.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test / test
  • GitHub Check: code-quality

@GuyEshdat GuyEshdat merged commit e938870 into master Dec 1, 2025
7 checks passed
@GuyEshdat GuyEshdat deleted the disable-slack-link-preview branch December 1, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

+1 more reviewer

@elazarlachkar elazarlachkar elazarlachkar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuyEshdat @elazarlachkar